Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors - remove SQL queries to discern relationships #2752

Open
MikeStall opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2753
Open

Connectors - remove SQL queries to discern relationships #2752

MikeStall opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2753
Assignees

Comments

@MikeStall
Copy link
Contributor

MikeStall commented Nov 25, 2024

SQL allows joins on any fields and does not tell us the join relationships.

This code was intended to get the relationships from SQL (similar to how we can get relationships from Dataverse):

@"{""query"":""SELECT fk.name AS FK_Name, '[' + sp.name + '].[' + tp.name + ']' AS Parent_Table, cp.name AS Parent_Column, '[' + sr.name + '].[' + tr.name + ']' AS Referenced_Table, cr.name AS Referenced_Column" +

(This was added relatively recently in #2550)

But it is not correct and should be removed. (Instead, it's telling us foreign key constraints. )

This means expressions would be written like:
LookUp(Table2, ThisRecord.Id2 = Id1).Field2

rather than
_tabld1Record.Id1.Field2

The LookUp is consistent with what PowerApps does today.

@LucGenetier LucGenetier linked a pull request Nov 26, 2024 that will close this issue
@LucGenetier LucGenetier linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants