New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify IAsyncTexlFunction #2751

Open

MikeStall opened this issue Nov 25, 2024 · 0 comments

Labels

Needs Discussion

Contributor

MikeStall commented Nov 25, 2024 •

edited

Loading

We shouldn't have 5+ variations of IAysncTexlFunction plus AsyncFunctionPtr delegate.

We should be able to remove this branch in EvalVisitor and have it be a single dispatch.

Power-Fx/src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs

Line 311 in 07a817b

    
           IReadOnlyDictionary<TexlFunction, IAsyncTexlFunction> extraFunctions = _services.GetService<IReadOnlyDictionary<TexlFunction, IAsyncTexlFunction>>();

Ideally, unify across:

builtin invocations
UDFs
Custom Functions (ReflectionFunction)

Broader design things to consider:

can we unify with StandardErrorHandlingAsync?
can we still follow Least-privilege? At least with many interfaces, the functions are describing statically which subset of functionality they need.

This is an engineering hygiene issue. Need to come up with a good design.

MikeStall added the Needs Discussion label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment