Try fixing the PTVS crash #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Nov 13, 2024
| @@ -1082,7 +1085,7 @@ protected override void Dispose(bool disposing) { | |||
|
|
|||
| _recreatingAnalyzer.Dispose(); | |||
| } | |||
|
|
|||
| _isDisposed = true; | |||
There was a problem hiding this comment.
Maybe it would be better to put this at the top before all the other things are removed? (In case one of them throws an exception.
Then you can also check if it's already disposed or not and throw an exception if it is.
rchiodo
approved these changes
Nov 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8060
I tried multiple ways including what users described in all similar issues but still wasn't able to repro the crash. From reading the call stacks looks like it's trying to call
GetProjectPropertyon a disposedPythonProjectNodeobject. So adding the check to return early if it's disposed. I did manually testing on all different scenarios and it doesn't crash or affect any behaviors. I will ask users to try again once the fix is shipped.