Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version expression reason #1828

Open
BernieWhite opened this issue May 24, 2024 · 0 comments
Open

Improve version expression reason #1828

BernieWhite opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working feature: output Issues that affect output and results

Comments

@BernieWhite
Copy link
Member

BernieWhite commented May 24, 2024 •
edited
Loading

For the case:

field: properties.grafanaMajorVersion
version: '>=10'

The outputted reason is Path properties.grafanaMajorVersion: The version '9.-1.-1' does not match the constraint 'PSRule.Data.SemanticVersion+VersionConstraint'.

This could be improved by:

  • Handling the -1 when the value is just 9 instead of 9.0.0.
  • Fix the string formatting for the constraint.

Example case: Azure/PSRule.Rules.Azure#2883
@BernieWhite BernieWhite added bug Something isn't working feature: output Issues that affect output and results labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature: output Issues that affect output and results
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BernieWhite