Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix #11

wants to merge 2 commits into from

Conversation

kantic
Copy link

@kantic kantic commented Apr 6, 2020

Suggested improvements:

  • Rename some of the wav files to have a uniform naming

  • strip the elements of the config parameter noise_types_excluded in order to allow comma separated list with spaces between the elements

  • read the config parameter total_snrlevels as int in order to avoid exception in the function np.linspace(...)

- renames noise_test/Neighbor*.wav to noise_test/NeighborSpeaking*.wav to conform to the naming in noise_train directory
- renames noise_train/AirportAnnouncement_11.wav to AirportAnnouncements_11.wav to conform to the other AirportAnnouncement noise files
- the config value total_snrlevels is read as int instead of float in order to avoid rutime error in np.linspace(...)
- strips the list of strings which is read from the config value noise_types_excluded in order to allow comma separated lists with spaces
  (as suggested in the documentation of the config file)
@msftclas
Copy link

msftclas commented Apr 6, 2020

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants