Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential problem with thresholds for bins around 0 #6589

Open
jaguerrerod opened this issue Aug 5, 2024 · 1 comment
Open

Potential problem with thresholds for bins around 0 #6589

jaguerrerod opened this issue Aug 5, 2024 · 1 comment
Labels

Comments

@jaguerrerod
Copy link

jaguerrerod commented Aug 5, 2024

I have a dataset with features with values -4, -3, -2, -1, 0, 1, 2, 3, 4
When I check the trees fitted I see cut points for bins -3.5, -2.5, -1.5, 1.5, 2.5, 3.5 all ok
But around 0 I see 1.0000000180025095e-35 and -1.0000000180025095e-35
Why not 0.5 and -0.5?
These extremely small values could be considered both 0 by the machine, and feature <= -1.0000000180025095e-35 could include 0 so both -1.0000000180025095e-35 and 1.0000000180025095e-35 would be the same cut point.
Why this election of cut points for bins?
image

@jameslamb
Copy link
Collaborator

@shiyu1994 can you please answer this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants