Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add reset_data to lgb.cv #1854

Closed
NamLQ opened this issue Nov 20, 2018 · 6 comments · Fixed by #1874
Closed

Please add reset_data to lgb.cv #1854

NamLQ opened this issue Nov 20, 2018 · 6 comments · Fixed by #1874

Comments

@NamLQ
Copy link

NamLQ commented Nov 20, 2018

The lgb.train has the argument reset_data = T to release the data from the model as in #879. In the case of multiple k-fold cv the RAM is eaten so fast, so it would much better if lgb.cv also has the argument reset_data.

Thank you very much.

@guolinke
Copy link
Collaborator

@NamLQ you can call gc every time after cv, since lgb.cv don't save cv-folds objects.

@guolinke
Copy link
Collaborator

sorry, it seems R-package returns a CV-booster.
@Laurae2 it that possible to only returns the cv-results like in python-package: https://github.com/Microsoft/LightGBM/blob/master/python-package/lightgbm/engine.py#L501 ?

@NamLQ
Copy link
Author

NamLQ commented Nov 25, 2018

Please keep the CV-booster, because I need it to make a fold prediction. So just release the data is enough.

@guolinke
Copy link
Collaborator

@Laurae2 @StrikerRUS
why the cv has different behaviours (return results) in python and R package.
Should we make them the same?

@guolinke
Copy link
Collaborator

@NamLQ updated

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Nov 25, 2018

@guolinke I've discovered LightGBM when cv had been already implemented, therefore I don't know.

Also, we have several issues about Python cv behavior enhancements: #283, #1445, #1105.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants