Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused vars from workflows #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove unused vars from workflows #74

wants to merge 5 commits into from

Conversation

t-young31
Copy link
Contributor

Resolves #61

I hit the same issue, so thought I'd propose a solution (tested and works ok)

What is being addressed

Workflows include inputs that are unused. The checks and references to TEST_APP_ID, TEST_WORKSPACE_APP_ID, TEST_WORKSPACE_APP_SECRET and MS_TEAMS_WEBHOOK_URI are removed. Also uses the value of $ec rather than the literal string, which I think is a 🐞

@marrobi marrobi mentioned this pull request Jun 16, 2023
Closed
LizaShak
LizaShak approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @marrobi I think that we should also create a PR in the main repo to remove the legacy use of it. In e2e_tests/helpers.py lines 117-120. WDYT? If you'd like I can do that.

@marrobi
Copy link
Member

marrobi commented Jun 28, 2023

LGTM. @marrobi I think that we should also create a PR in the main repo to remove the legacy use of it. In e2e_tests/helpers.py lines 117-120. WDYT? If you'd like I can do that.

@LizaShak I'm not 100% what those lines are for? If not used anywhere then they should go...

@tamirkamara
Copy link
Contributor

@marrobi @LizaShak This PR is likely to overwritten when the next release happens as we only compare in the TRE->Deployment direction.

@marrobi
Copy link
Member

marrobi commented Jun 28, 2023

@tamirkamara so what are you suggesting? Should these variables made optional in the microsoft/AzureTRE repository instead? If can provide some guidance then maybe we can work to resolve.

@jonnyry
Copy link
Contributor

jonnyry commented Nov 29, 2023 •
edited
Loading

$ec bug described in microsoft/AzureTRE#3778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizaShak LizaShak LizaShak approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variable name missmatch
5 participants
@t-young31 @marrobi @tamirkamara @jonnyry @LizaShak