Skip to content
This repository has been archived by the owner on Oct 31, 2019. It is now read-only.

Look for config file in ~/.azuresmr when running tests #78

Open
yueguoguo opened this issue Jun 14, 2017 · 1 comment
Open

Look for config file in ~/.azuresmr when running tests #78

yueguoguo opened this issue Jun 14, 2017 · 1 comment
Assignees
@andrie
Labels
tests

Comments

@yueguoguo
Copy link
Contributor

Should settingsfile <- system.file("tests/testthat/config.json", package = "AzureSMR") be replaced by settingsfile <- getOption("AzureSMR.config") in the testing scripts? @andrie
@andrie
Copy link
Contributor

andrie commented Jun 14, 2017

Yes, ultimately it should.

Right now it has the benefit that the file used for settings is in the same location as the package, making it easy to manage your test settings with the package.

However, this fails R CMD check.

@andrie andrie self-assigned this Jun 16, 2017
@andrie andrie added the tests label Jun 16, 2017
@andrie andrie changed the title Testing config files. Look for config file in ~/.azuresmr when running tests Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrie andrie

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrie @yueguoguo