Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen height on tablet vs keyboard #1162

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Screen height on tablet vs keyboard #1162

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3628e62
Debug logging
microbit-grace Apr 3, 2024
5848e9e
Set overflow as hidden
microbit-grace Apr 3, 2024
55b5d3c
Use visual viewport css for Android
microbit-grace Apr 3, 2024
be63cca
Try using 100svh for height
microbit-grace Apr 3, 2024
a9759d6
Add resize content config in viewport
microbit-grace Apr 3, 2024
2f49f26
Apply svh and fallback
microbit-grace Apr 3, 2024
acaa12b
Set 100svh for height for non-iOS
microbit-grace Apr 3, 2024
43ccb90
Update comments
microbit-grace Apr 3, 2024
86d25a2
Use full height of screen even when keyboard triggered
microbit-grace Apr 4, 2024
70ba3ee
Add overflow hidden and 100% height
microbit-grace Apr 4, 2024
640c5e4
Do not render simulator when collapsed
microbit-grace Apr 4, 2024
e6313d0
Use min height of sidebar as the workbench min height
microbit-grace Apr 4, 2024
70e4dd6
Set min-width and min-height
microbit-grace Apr 4, 2024
0800b1d
Remove visual viewport CSS variable component
microbit-grace Apr 4, 2024
bb77f91
Revert "Do not render simulator when collapsed"
microbit-grace Apr 4, 2024
11886ee
Display simulator none when collapsed
microbit-grace Apr 4, 2024
5ef82f8
Organise imports
microbit-grace Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8" />
<link rel="icon" href="%BASE_URL%favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="viewport" content="width=device-width, initial-scale=1, interactive-widget=resizes-content" />
<meta name="theme-color" content="#6c4bc1" />
<title>micro:bit Python Editor</title>
<meta property="og:title" content="micro:bit Python Editor" />
Expand Down
5 changes: 3 additions & 2 deletions src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ body,
.WorkbenchContainer,
.Workbench {
width: 100%;
/* --ios-vvh set by VisualViewPortCSSVariables on iOS only. */
height: var(--ios-vvh, var(--webkit-vvh, 100vh));
/* --vvh set by VisualViewPortCSSVariables */
height: var(--vvh, var(--webkit-vvh, 100vh));
overflow: hidden;
}
body {
overflow: hidden;
Expand Down
31 changes: 17 additions & 14 deletions src/common/VisualViewportCSSVariables.tsx
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed since we are aiming to have the keyboard overlay the UI instead of having a shifting action bar

Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,31 @@ const isIOS = (): boolean =>

/**
* Maintains CSS variables for the visual viewport width and height.
* Use with fallbacks, e.g. var(--ios-vvh, 100vh)
* Use with fallbacks, e.g. var(--vvh, 100vh)
* https://developer.mozilla.org/en-US/docs/Web/API/Visual_Viewport_API
*
* This is important for iOS where we want to avoid the keyboard being
* drawn over the toolbar at the bottom.
*
* We skip it on other platforms and rely on the fallback.
*/
const VisualViewPortCSSVariables = () => {
const addStyleInnerText = (innerText: string) => {
let style = document.getElementById(styleId);
if (!style) {
style = document.head.appendChild(document.createElement("style"));
style.id = styleId;
}
style.innerText = innerText;
};

useEffect(() => {
// If we remove the iOS check then we should look carefully at resize performance.
if (!window.visualViewport || !isIOS()) {
// svh on Safari in iOS does not resize when virtual keyboard is present
if (CSS.supports("height: 100svh") && !isIOS) {
addStyleInnerText(":root { --vvh: 100svh }");
return;
}
microbit-grace marked this conversation as resolved.
Show resolved Hide resolved
if (!window.visualViewport) {
return;
}
microbit-grace marked this conversation as resolved.
Show resolved Hide resolved
const resizeHandler = () => {
const { width, height } = window.visualViewport ?? {};
let style = document.getElementById(styleId);
if (!style) {
style = document.head.appendChild(document.createElement("style"));
style.id = styleId;
}
style.innerText = `:root { --ios-vvw: ${width}px; --ios-vvh: ${height}px; }`;
addStyleInnerText(`:root { --vvw: ${width}px; --vvh: ${height}px; }`);
};
window.visualViewport.addEventListener("resize", resizeHandler);
resizeHandler();
Expand Down
Loading