Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen height on tablet vs keyboard #1162

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Screen height on tablet vs keyboard #1162

wants to merge 17 commits into from

Commits on Apr 3, 2024

  1. Debug logging

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3628e62 View commit details
    Browse the repository at this point in the history

  2. Set overflow as hidden

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5848e9e View commit details
    Browse the repository at this point in the history

  3. Use visual viewport css for Android 

    not only iOS
    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    55b5d3c View commit details
    Browse the repository at this point in the history

  4. Try using 100svh for height

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    be63cca View commit details
    Browse the repository at this point in the history

  5. Add resize content config in viewport

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a9759d6 View commit details
    Browse the repository at this point in the history

  6. Apply svh and fallback

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2f49f26 View commit details
    Browse the repository at this point in the history

  7. Set 100svh for height for non-iOS

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    acaa12b View commit details
    Browse the repository at this point in the history

  8. Update comments

    @microbit-grace
    microbit-grace committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    43ccb90 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Use full height of screen even when keyboard triggered

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    86d25a2 View commit details
    Browse the repository at this point in the history

  2. Add overflow hidden and 100% height

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    70ba3ee View commit details
    Browse the repository at this point in the history

  3. Do not render simulator when collapsed 

    Removes extra space on the right of HTML when the simulator is closed
    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    640c5e4 View commit details
    Browse the repository at this point in the history

  4. Use min height of sidebar as the workbench min height

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e6313d0 View commit details
    Browse the repository at this point in the history

  5. Set min-width and min-height

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    70e4dd6 View commit details
    Browse the repository at this point in the history

  6. Remove visual viewport CSS variable component

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0800b1d View commit details
    Browse the repository at this point in the history

  7. Revert "Do not render simulator when collapsed" 

    This reverts commit 640c5e4.
    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    bb77f91 View commit details
    Browse the repository at this point in the history

  8. Display simulator none when collapsed

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    11886ee View commit details
    Browse the repository at this point in the history

  9. Organise imports

    @microbit-grace
    microbit-grace committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5ef82f8 View commit details
    Browse the repository at this point in the history