Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 #1130

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Upgrade to Node 20 #1130

merged 2 commits into from
Sep 21, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

Drop webusb dep that's only used for some test we largely didn't complete. Replace the working test with a mock as its use of the webusb dep wasn't meaningful.

Drop webusb dep that's only used for some test we largely
didn't complete. Replace the working test with a mock as its
use of the webusb dep wasn't meaningful.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/node-20/

@microbit-matt-hillsdon
Copy link
Collaborator Author

@microbit-robert I've fixed the build issue.

@microbit-matt-hillsdon
Copy link
Collaborator Author

Remaining npm audit issues are in react-scripts (so dev time only) and will be addressed by moving to Vite at some point.

Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Build looks good.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit e83100e into main Sep 21, 2023
1 check passed
Amerlander added a commit to calliope-edu/calliope-mini-python-editor that referenced this pull request Nov 5, 2024
Drop webusb dep that's only used for some test we largely
didn't complete. Replace the working test with a mock as its
use of the webusb dep wasn't meaningful.

Bump to working source-map-explorer (has dep fixes for Node
18+).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants