Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landmark elements and regions for navigation #527

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

microbit-robert
Copy link

@microbit-robert microbit-robert commented Nov 19, 2024

Also:

  • fixes an issue where extra and seemingly unnecessary vertical scroll is present on the data samples page due to the icon picker.
  • fixes icon picker positioning

Regions as of this PR:

  • header with the app-wide actions
  • main containing the table-like area
    • named action regions
  • "data samples toolbar" or "testing model toolbar" containing the page specific actions (intentionally avoided the word action here)
  • live graph

We think the live graph makes sense as a separate region as the other actions aren't related to it and are different per page. It's also something we talk about a lot in docs etc.

See #517

Copy link

Preview build will be at
https://review-createai.microbit.org/regions/

lang/ui.en.json Outdated Show resolved Hide resolved
lang/ui.en.json Outdated Show resolved Hide resolved
@microbit-robert
Copy link
Author

microbit-robert commented Nov 19, 2024

Converting to draft as we need the regions for each action on the testing model page as well, which will hopefully improve the speed of navigation to the recognition point input.

Edit: Now done.

@microbit-robert microbit-robert marked this pull request as ready for review November 19, 2024 13:36
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll get Kirsty's feedback on this and iterate if needed but let's get it in as a first cut.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit ac1a3e8 into main Nov 19, 2024
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the regions branch November 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants