-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landmark elements and regions for navigation #527
Conversation
Preview build will be at |
Converting to draft as we need the regions for each action on the testing model page as well, which will hopefully improve the speed of navigation to the recognition point input. Edit: Now done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll get Kirsty's feedback on this and iterate if needed but let's get it in as a first cut.
Also:
Regions as of this PR:
We think the live graph makes sense as a separate region as the other actions aren't related to it and are different per page. It's also something we talk about a lot in docs etc.
See #517