Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-live assertive for recording countdown #370

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

microbit-grace
Copy link

@microbit-grace microbit-grace commented Oct 10, 2024

No description provided.

Copy link

Preview build will be at
https://review-createai.microbit.org/countdown-live/

@microbit-grace microbit-grace marked this pull request as ready for review October 10, 2024 08:53
@microbit-grace microbit-grace requested a review from a team October 10, 2024 08:53
@microbit-robert
Copy link

This kind of works and kind of doesn't. NVDA is too busy reading out things from previous focus, current focus, and the fact that a dialog has appeared. It's just too slow to be useful. It continues to read 3, 2, 1 etc, but it's well behind what is changing on screen. By the time it says "recording", the recording has practically finished.

The progress bar has some built in aria-live features. For NVDA it's an incredibly irritating noise starting low in pitch and getting higher until it stops.

Windows narrator does a slightly better job. It is busy reading that a close button is focussed, misses the start of the countdown, but keeps pace. It's normally "2 , 1..." or "1, recording". It also doesn't produce a noise during the progress dialog transition.

I don't really know the best way to fix this. There could well be options in the screen reader settings that would improve the experience.

One thing we don't do at the moment is tell you when the recording stops. You only get a sense that it does because a different button becomes focussed when the dialog closes.

@microbit-grace
Copy link
Author

This kind of works and kind of doesn't. NVDA is too busy reading out things from previous focus, current focus, and the fact that a dialog has appeared. It's just too slow to be useful. It continues to read 3, 2, 1 etc, but it's well behind what is changing on screen. By the time it says "recording", the recording has practically finished.

The progress bar has some built in aria-live features. For NVDA it's an incredibly irritating noise starting low in pitch and getting higher until it stops.

Windows narrator does a slightly better job. It is busy reading that a close button is focussed, misses the start of the countdown, but keeps pace. It's normally "2 , 1..." or "1, recording". It also doesn't produce a noise during the progress dialog transition.

I don't really know the best way to fix this. There could well be options in the screen reader settings that would improve the experience.

Hmm.. sounds like the experience for NVDA and windows narrator are different to Mac voice over experience. 🤔 Below is a video for what I experience using the Mac voice over.

Screen.Recording.2024-10-10.at.13.21.31.mov

I'm not sure what's the best way to fix this too.

@microbit-grace
Copy link
Author

One thing we don't do at the moment is tell you when the recording stops. You only get a sense that it does because a different button becomes focussed when the dialog closes.

Maybe adding a toast that says "Recording added" or something along those lines could hint to the user that the recording has stopped? Suggestions welcomed

@microbit-robert
Copy link

Well, the recording countdown works beautifully with Mac voice over.

@microbit-matt-hillsdon
Copy link

Parking this one until we can try out in person and discuss next week.

@microbit-robert
Copy link

You can hit the NVDA key + spacebar when the dialog opens to stop it reading out the dialog info and just listen to the aria-live region which then works pretty well. I want to explore NVDA settings / modes to see if we can suggest something that will work well for the recording process.

@microbit-robert
Copy link

You can hit the NVDA key + spacebar when the dialog opens to stop it reading out the dialog info and just listen to the aria-live region which then works pretty well. I want to explore NVDA settings / modes to see if we can suggest something that will work well for the recording process.

Seems like you can just hit CTRL when the dialog opens to interupt NVDA, it will then announce the countdown. This is not a very practical fix as it requires relatively quick reactions and fine motor skills.

@microbit-robert microbit-robert marked this pull request as ready for review November 22, 2024 12:43
@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 2a26c85 into main Nov 22, 2024
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the countdown-live branch November 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants