From 088a428579ad4f7851cc5555ef901ab259337a55 Mon Sep 17 00:00:00 2001
From: Grace <grace@microbit.org>
Date: Tue, 3 Dec 2024 12:55:27 +0000
Subject: [PATCH] Remove open settings dialog shortcut

There is ambiguity as to which keys to use and there needs to be a way of disabling certain keys when dialogs are open
---
 src/components/ActionBar/ActionBarItemsRight.tsx | 5 -----
 src/keyboard-shortcuts.ts                        | 1 -
 2 files changed, 6 deletions(-)

diff --git a/src/components/ActionBar/ActionBarItemsRight.tsx b/src/components/ActionBar/ActionBarItemsRight.tsx
index cb91afab5..9acc16670 100644
--- a/src/components/ActionBar/ActionBarItemsRight.tsx
+++ b/src/components/ActionBar/ActionBarItemsRight.tsx
@@ -52,11 +52,6 @@ const ItemsRight = ({ menuItems, toolbarItems }: ItemsRightProps) => {
       }
     }
   }, [tourTriggerName]);
-  useHotkeys(
-    keyboardShortcuts.settings,
-    settingsDisclosure.onOpen,
-    globalShortcutConfig
-  );
   return (
     <>
       <LanguageDialog
diff --git a/src/keyboard-shortcuts.ts b/src/keyboard-shortcuts.ts
index a2ac91965..6423161de 100644
--- a/src/keyboard-shortcuts.ts
+++ b/src/keyboard-shortcuts.ts
@@ -3,7 +3,6 @@ export const keyboardShortcuts = {
   // This is scoped by keyboard focus.
   addAction: ["ctrl+shift+enter", "meta+shift+enter"],
   saveSession: ["ctrl+shift+s", "meta+shift+s"],
-  settings: ["ctrl+shift+p", "meta+shift+p"],
   nextAction: ["down"],
   previousAction: ["up"],
   renameAction: ["F2"],