New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UICR: End address might be misscalculated if start page is not 0 #24

Open

microbit-carlos opened this issue May 11, 2020 · 0 comments

Labels

bug

Collaborator

microbit-carlos commented May 11, 2020

microbit-fs/src/uicr.ts

Lines 200 to 208 in 9738a5b

    
           return { 
        
             flashPageSize: pageSize, 
        
             runtimeStartPage: startPage, 
        
             runtimeStartAddress: startPage * pageSize, 
        
             runtimeEndUsed: pagesUsed, 
        
             runtimeEndAddress: pagesUsed * pageSize, 
        
             versionAddress, 
        
             version, 
        
           };

Will need to check that runtimeEndUsed represents numbers of pages used from the start page: https://microbit-micropython.readthedocs.io/en/latest/devguide/hexformat.html#uicr-format

Then update the code and add more tests.

The text was updated successfully, but these errors were encountered:

microbit-carlos added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment