Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify demands at least 2 chars in name, name field description is inaccurate #948

Open
SteveMicroNova opened this issue Sep 27, 2024 · 1 comment
Labels
bug Something isn't working webapp Web application development
Milestone

Comments

@SteveMicroNova
Copy link
Contributor

SteveMicroNova commented Sep 27, 2024

image
The text underneath the name textbox says "This can be anything you like!" but that isn't strictly true; Spotify demands at least two non-special chars (so "1" is invalid, "11" is valid, "1-" is invalid, "1-1" is valid again due to two of the chars being non-special)

I would've whipped up a quick fix for this by doing something like this:

const NAME_DESC = ( 
  streamType == "spotify"
  ?
  "This name requires a minimum of two non-special characters - it will be used to select this stream from the source selection dropdown" 
  :
  "This name can be anything - it will be used to select this stream from the source selection dropdown"
);

In StreamModal.jsx, but that file doesn't seem to be aware of the stream type being created

@SteveMicroNova SteveMicroNova changed the title Spotify demands at least 2 chars in name, name field description is innaccurate Spotify demands at least 2 chars in name, name field description is inaccurate Sep 27, 2024
@SteveMicroNova
Copy link
Contributor Author

I'm also finding that some chars are outright illegal, will need proper testing but I think that underscores and slashes are both illegal for spotify

@SteveMicroNova SteveMicroNova added this to the 0.5.0 milestone Sep 30, 2024
@SteveMicroNova SteveMicroNova added bug Something isn't working webapp Web application development labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working webapp Web application development
Projects
None yet
Development

No branches or pull requests

1 participant