-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship DemoCamera with pymmcore #19
Comments
Yes, that sounds like a really good idea to me, too. Some logistical challenges might need to be solved around (1) building DemoCamera from Awesome to see the notebook in action! |
I also think this would be a nice idea. I'll point out that, in the meantime, the |
@tlambert03 Yeah, I saw your install feature and like it a lot (pymmcore's README now mentions pymmcore-plus, btw). Good to have it mentioned here. I'm not sure it is worth trying to come up with an ad hoc way to build one device adapter (or a few, including Utilities) as part of pymmcore. It's hard to do correctly (or at least identically to the official MM build) using setuptools, whose limits we are already pushing. Switching to a more capable build system (e.g. Meson, which works with PEP 518) would make it doable, but I think such effort should first be directed toward improving the build system of the main MM project so that we don't have to come up with a pymmcore-specific solution. Once that's done, we'll certainly include DemoCamera in pymmcore. |
if I may slightly hijack this thread with a quick question (related to installing device adapters): |
@tlambert03 I can't think of a good way at the moment, since we don't tag the commits used for nightly builds. The intent is to keep supporting, say, 70-compatible pymmcore for a while after MMDevice is bumped to 71 (maybe until the next official MM release, since we have those again now). In other words, it will be possible to determine the correct version of pymmcore based on the MM installation, but not the other way around. But there could always be a few day's delay between the MMDevice version bump and the release of the corresponding pymmcore. I suppose it wouldn't be that hard for us to publish a correspondence table (static JSON) that is automatically updated every day (seems doable with pymmcore-plus + GitHub Actions+Pages). Does that sound useful? (If yes, maybe let's start a new issue.) |
Following the hints in #18, I manage to build a DemoCamera device adapter that works in Docker, it's very helpful for development and demo purpose. So I am wondering whether it make sense to build and ship the demo device adapter directly with pymmcore, so I don't even need to fetch a binary version elsewhere.
Here is the demo jupyter notebook I made: (BTW, we can link to this repo as an example if you like.)
The text was updated successfully, but these errors were encountered: