Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Issue with Acquisition Notification #760

Closed
carlkesselman opened this issue Apr 15, 2024 · 3 comments
Closed

Potential Issue with Acquisition Notification #760

carlkesselman opened this issue Apr 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@carlkesselman
Copy link
Contributor

I have the latest version of micromanager and pyro manager installed. I'm getting a funny error in acquisition notification:

File "C:\Users\carl\Repos\pycro-manager\pycromanager\acquisition\acq_eng_py\main\acq_notification.py", line 94, in from_json
    return AcqNotification(json['type'],
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\carl\Repos\pycro-manager\pycromanager\acquisition\acq_eng_py\main\acq_notification.py", line 60, in __init__
    raise ValueError(f"Unknown milestone: {milestone}")
ValueError: Unknown milestone: pre_z_drive

I modified the Value error to see what the error was, and as you can see its pre_z_drive.

Any idea of what could be causing this?

Thanks,

Carl

@henrypinkard
Copy link
Member

Yes, caused by a new notification type being added and the tests being skipped. I will try to get a fix up today

@henrypinkard
Copy link
Member

Should be fixed in new version #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants