Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #662

Open
goanpeca opened this issue Aug 3, 2023 · 3 comments
Open

Update requirements #662

goanpeca opened this issue Aug 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@goanpeca
Copy link

goanpeca commented Aug 3, 2023

Hi team, in working on the conda forge package for the latest release

conda-forge/pycromanager-feedstock#29

We noticed that the tarball is not including the requirements.txt file:
https://github.com/micro-manager/pycro-manager/blob/main/requirements.txt

Which will result in a broken package when installing from a tarball

    File "/home/conda/feedstock_root/build_artifacts/pycromanager_1691005638576/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.11/site-packages/setuptools/build_meta.py", line 338, in run_setup
      exec(code, locals())
    File "<string>", line 14, in <module>
  FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
  error: subprocess-exited-with-error

I am going to add a dummy requirements.txt as the rest of the conda dependencies will be provided by the recipe meta.yaml.

Using this sort of install procedure (relying on an external requirements.txt) file is not recommended. Could you look into other ways of specifying dependencies? for instance using a setup.cfg file as described here.

Cheers!

@ieivanov
Copy link
Collaborator

ieivanov commented Aug 4, 2023

Thanks for raising this issue @goanpeca! As I understand it, the community is moving towards using pyproject.toml, I can make that change here.

@goanpeca
Copy link
Author

goanpeca commented Aug 4, 2023

That works too! Thanks :)

@ieivanov
Copy link
Collaborator

ieivanov commented Aug 5, 2023

Another missing dependency: docstring_inheritance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants