From 6c095716470b0a35548d63459df4aa367248b9a1 Mon Sep 17 00:00:00 2001
From: Henry Pinkard <7969470+henrypinkard@users.noreply.github.com>
Date: Tue, 18 Jun 2024 21:22:32 +0200
Subject: [PATCH] add 8 bit test and update to ndstorage with bug fixed

---
 pycromanager/_version.py              |  2 +-
 pycromanager/test/test_acquisition.py | 20 ++++++++++++++++++++
 requirements.txt                      |  2 +-
 3 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/pycromanager/_version.py b/pycromanager/_version.py
index a5baebcb..db276572 100644
--- a/pycromanager/_version.py
+++ b/pycromanager/_version.py
@@ -1,2 +1,2 @@
-version_info = (0, 34, 3)
+version_info = (0, 34, 4)
 __version__ = ".".join(map(str, version_info))
diff --git a/pycromanager/test/test_acquisition.py b/pycromanager/test/test_acquisition.py
index f11a149d..d4b5b1f0 100644
--- a/pycromanager/test/test_acquisition.py
+++ b/pycromanager/test/test_acquisition.py
@@ -666,5 +666,25 @@ def test_empty_axes(launch_mm_headless, setup_data_folder):
     dataset = acq.get_dataset()
     try:
         assert dataset.read_image() is not None and dataset.read_image().max() > 0
+    finally:
+        dataset.close()
+
+
+def test_8bit(launch_mm_headless, setup_data_folder):
+    """
+    Test that images with empty axes are correctly saved
+    """
+    events = multi_d_acquisition_events(10)
+    core = Core()
+    core.set_property('Camera', 'BitDepth', '8')
+    core.set_property('Camera', 'PixelType', '8bit')
+
+    with Acquisition(setup_data_folder, 'test_8_bit', show_display=False) as acq:
+        acq.acquire(events)
+
+    dataset = acq.get_dataset()
+    try:
+        image_coordinates = events[0]['axes']
+        assert dataset.read_image(**image_coordinates) is not None and dataset.read_image(**image_coordinates).max() > 0
     finally:
         dataset.close()
\ No newline at end of file
diff --git a/requirements.txt b/requirements.txt
index b54ee154..cdcde29e 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,7 @@
 numpy
 dask[array]>=2022.2.0
 pyzmq
-ndstorage>=0.1.5
+ndstorage>=0.1.6
 docstring-inheritance
 pymmcore
 sortedcontainers