Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDBReact to Best of JS #414

Closed
3 of 4 tasks
Speedwares opened this issue Aug 28, 2021 · 7 comments
Closed
3 of 4 tasks

Add CDBReact to Best of JS #414

Speedwares opened this issue Aug 28, 2021 · 7 comments

Comments

@Speedwares
Copy link

https://github.com/Devwares-Team/cdbreact

Best of JavaScript is for the most popular open-source projects related to the web platform and Node.js.

Before submitting the request to add a new project, please check the following points:

  • The project is related to the web platform or Node.js
  • The project has more than 100 stars on GitHub
  • The project has thorough documentation in English
  • The project is not deprecated and actively maintained

How would this project be tagged? (Pick one or several existing tags from this list: https://bestofjs.org/tags)

CSS Toolkit, Component Toolkit

@Speedwares Speedwares changed the title Add <project name> to Best of JS Add CDBReact to Best of JS Aug 28, 2021
@michaelrambeau
Copy link
Owner

Hello @Speedwares thank you for the recommendation.

I was checking the demo and I wanted to see how components look like in the Dark Mode but it seems that nothing happens when I click on the 🌔 button?

It's not a big deal but in the left side bar, the active state of the menu item looks a bit weird (the icon is not at the center of its white square container)

Screenshot in Firefox:

image

@Speedwares
Copy link
Author

Hey @michaelrambeau thank you so much for taking the time to go through contrast and the detailed response. Really appreciate it and am so sorry for the late response on this.

Yes, you are absolutely right about the dark mode button it is not actually working because we did not add that feature to it. the icon was meant for in case someone wanted to add it to their dashboard, they could easily have an icon button already for the functionality.

On the second issue, that's really weird. It does look very out of place that way I will try to replicate it today, fix it up and let you know.

Thanks again for taking the time to go through

@L1lith
Copy link
Contributor

L1lith commented Sep 7, 2021

@Speedwares Hey there, I've created a few issues on the project repo and would love to hear your feedback. I think these changes could help polish up your library, but you're welcome to take the suggestions at your discretion.
Devwares-Team/cdbreact#6
Devwares-Team/cdbreact#5
Devwares-Team/cdbreact#4

@Speedwares
Copy link
Author

Hey, @L1lith thank you very much for taking the time to create those issues and even leaving code examples, appreciate it! I am currently working on some improvements to the library and these were all awesome suggestions, thank you again. Hoping to get out those improvements which also fixes the issue Michael brought to my notice above in the next few days.
I will make sure to incorporate these issues fixes as well into the update. 🙏

@Speedwares
Copy link
Author

Speedwares commented Jan 19, 2022

Hey @michaelrambeau ,

So sorry I forgot to get back to you on this. I fixed up the issue back then but forgot to update this thread. Could you consider looking at this again. Thank you so much!

Regards

@michaelrambeau
Copy link
Owner

Hello @Speedwares
OK thank you for the update, CDBReact will be available on Best of JS very soon.

@Speedwares
Copy link
Author

Thank you so much for responding @michaelrambeau. Hugely looking forward to it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants