Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer compatible with setuptools>=58 #12

Open
jonringer opened this issue Feb 16, 2022 · 5 comments
Open

No longer compatible with setuptools>=58 #12

jonringer opened this issue Feb 16, 2022 · 5 comments

Comments

@jonringer
Copy link

They dropped support for use_2to3 in setuptools==58, package will fail to build:

       > error in pyownet setup command: use_2to3 is invalid.

version: 0.10.0.post1

@miccoli
Copy link
Owner

miccoli commented Feb 16, 2022

Thanks for reporting... this is a very old codebase and it's time to drop python2 support and create a python3 only release!

Fortunately it is quite simple to do, since python3 was already the main development language, and the 2to3 fixes are quite trivial.

I will fix this issue in the 0.11.0 release. The wheels on pypi are unaffected, so it should be possible to install them as usual.

@miccoli miccoli added this to the Release py3 only 0.11.0 milestone Feb 16, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 6, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 6, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 6, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 7, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 7, 2022
mweinelt added a commit to NixOS/nixpkgs that referenced this issue Mar 8, 2022
@onkelbeh
Copy link

I have added a patch to my Repo to keep it running:
onkelbeh/HomeAssistantRepository@1a4bce4

@zdzichu
Copy link

zdzichu commented Jan 31, 2023

Hey @miccoli, I started packaging pyownet for Fedora and encountered this exact issue.
Are you ready to release python3-only 0.11.0 release? It would be appreciated :)

@miccoli
Copy link
Owner

miccoli commented Jan 31, 2023

@zdzichu sorry, I'm not ready to release 0.11.0 soon. However I tested the PEP 517 build API in 1b2e8d1 , and it seems that it is working as expected.

I do not know how are the Fedora python packages are constructed, but a straightforward PEP 517 packaging strategy could be

/usr/bin/python -m build --wheel
/usr/bin/python -m installer --destdir="$pkgdir" dist/*.whl

using the build and installer python packages.

If a PEP517 compliant installation is of use for Fedora, I can backport 1b2e8d1 to a new 0.10.1 release.

@zdzichu
Copy link

zdzichu commented Dec 28, 2023

Hey @miccoli,
I redid the packaging, using 1b2e8d1
It looks like it is building fine!
I've opened a review request to have the package included in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=2256125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants