Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't sanitize number #15

Open
afeld opened this issue Feb 13, 2015 · 1 comment
Open

don't sanitize number #15

afeld opened this issue Feb 13, 2015 · 1 comment

Comments

@afeld
Copy link

afeld commented Feb 13, 2015

I haven't looked through all the code, but I think it's better (Principle of Least Surprise-wise) for people to see exactly the number that they put in.

https://github.com/mhs/sms-spec/blob/d93fd847387f5fabc0c03c5363bf8af66ea2cf2a/lib/sms_spec/util.rb

Credit to @monfresh for the idea.

@monfresh
Copy link

If anyone is interested, I've fixed this in my fork: https://github.com/monfresh/sms-spec
monfresh@786238c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants