Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google cloud storage compatability #59

Open
tomlarkworthy opened this issue Sep 24, 2023 · 0 comments
Open

Google cloud storage compatability #59

tomlarkworthy opened this issue Sep 24, 2023 · 0 comments

Comments

@tomlarkworthy
Copy link

I love this lib. I have tested it successfully with S3, minio, backblaze and R2. However, I am getting stuck with GCS. I have not worked out the root problem yet, I suspect GCS requires signed content-lengh headers or something, which is explicitly turned off in this library (for proxy support?)
Just wondering how open you are for a PR in this direction, I think GCS XML might work too differently to the others, do you want to support more vendors?
I think if I were to try and fix it I would declare the service "GCS" instead of "S3" and use that as the hook for feature flags. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant