Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firebase deploy script to latest from firebase CLI #74

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mhansen
Copy link
Owner

@mhansen mhansen commented Apr 10, 2024

Generated with firebase init hosting:github

I'm hoping this will fix my errors with pull requests not having access to the secret key, maybe? But I don't know how it would. I'm just ruling it out at this stage that there's no fix by updating.

Generated with firebase init hosting:github

I'm hoping this will fix my errors with pull requests not having access to the
secret key, maybe? But I don't know how it would. I'm just ruling it out at
this stage that there's no fix by updating.
Copy link

Visit the preview URL for this PR (updated for commit ab11944):

https://nzwirelessmap-firebase--pr74-firebase-erzky72f.web.app

(expires Wed, 17 Apr 2024 08:44:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c1dc796c624d739a970a4d904012cca18031bf15

@mhansen
Copy link
Owner Author

mhansen commented Apr 10, 2024

I think this bit probably fixes it:

    if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'

This will stop it running from dependabot's fork

@mhansen mhansen merged commit 5a3b24f into master Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant