Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most config options don't work in config.exs? #74

Open
nickjj opened this issue Jul 19, 2018 · 4 comments
Open

Most config options don't work in config.exs? #74

nickjj opened this issue Jul 19, 2018 · 4 comments

Comments

@nickjj
Copy link

nickjj commented Jul 19, 2018

Hi,

If I set the following in my config.exs file, only the view_style takes effect:

config :scrivener_html,
  routes_helper: MyApp.Router.Helpers,
  view_style: :bootstrap_v4,
  distance: 5, next: "Next", previous: "Previous",
  first: true, last: true

I would have expected the other config options to be applied as well.

I wanted to do this because I have pagination on 4 different resources, and I didn't want to have to customize the next, previous, etc. for each one individually but currently that seems to be the only way to do it.

Also on a side note, first / last never show up, even if I set them directly on pagination_links in my eex template.

I'm running 1.7.1 (the latest release at the time of this issue).

@mgwidmann
Copy link
Owner

Yep, looks like we just pull the application environment config for those values
https://github.com/mgwidmann/scrivener_html/blob/master/lib/scrivener/html.ex#L98

I would accept a PR to make this addition.

@shulhi
Copy link
Contributor

shulhi commented Mar 13, 2019

@mgwidmann I can definitely help with this once you have the time to review #86 and then I can work on top of that PR.

@mgwidmann
Copy link
Owner

Ping, going to close this soon if no one wants this feature.

@nickjj
Copy link
Author

nickjj commented Dec 17, 2019

I think people do want it. I know I still do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants