Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dat.ErrNotFound #37

Open
sbowman opened this issue Feb 27, 2016 · 1 comment
Open

Remove dat.ErrNotFound #37

sbowman opened this issue Feb 27, 2016 · 1 comment

Comments

@sbowman
Copy link

sbowman commented Feb 27, 2016

Half the query functions in dat use the standard "sql.ErrNoRows" and half use "dat.ErrNotFound". Could you please just standardize on "sql.ErrNoRows" and drop "dat.ErrNotFound", so we can stop having to guess which is which or testing for both all the time?

@mgutz
Copy link
Owner

mgutz commented Mar 1, 2016

I agree with this. dat used to work with another postgres driver (pgx) and I was being too clever in my abstractions. The next version will remove it. I can't remove it from the current version as it will break API compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants