Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization roundripping of Template Haskell datatypes disabled due to Bytes' Eq instance #150

Open
mgsloan opened this issue Apr 4, 2020 · 2 comments
Open

Serialization roundripping of Template Haskell datatypes disabled due to Bytes' Eq instance #150

mgsloan opened this issue Apr 4, 2020 · 2 comments
Labels
testing

Comments

@mgsloan
Copy link
Owner

mgsloan commented Apr 4, 2020

The Bytes type in template-haskell-2.16.0.0 uses derived Eq instances, which uses pointer equality, even though it is semantically similar to ByteString. This causes the serialization roundtrip tests to fail for some Template Haskell types, so I have disabled those tests. This issue tracks re-enabling them if this is fixed upstream.
@mgsloan mgsloan added the testing label Apr 4, 2020
mgsloan added a commit that referenced this issue Apr 4, 2020
@mgsloan
Disable serialization roundtrip testing of TH instances #150 #149
2d956e5
@RyanGlScott
Copy link
Contributor

Is there an upstream GHC issue about this?

@mgsloan
Copy link
Owner Author

mgsloan commented Apr 4, 2020

There is not, but I just added a comment to an issue which seems to be collecting a list of gnarlyness about Bytes - https://gitlab.haskell.org/ghc/ghc/issues/16457#note_263611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgsloan @RyanGlScott