Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PHPStan to level 2. #266

Closed
mglaman opened this issue Mar 2, 2022 · 1 comment · Fixed by #267
Closed

Bump PHPStan to level 2. #266

mglaman opened this issue Mar 2, 2022 · 1 comment · Fixed by #267

Comments

@mglaman
Copy link
Owner

mglaman commented Mar 2, 2022 •
edited
Loading

Many deprecations are missed due to PHPStan not detecting correct methods because code is not typed appropriately. Solving "undefined methods" will fix detection of deprecated methods. To do so, we'd need to bump to level 2.

Examples of why we need to:
@mglaman mglaman mentioned this issue Mar 3, 2022
Merged
@mglaman mglaman pinned this issue Mar 10, 2022
@jkribeiro
Copy link

I just think it should have been done in a Major release, but that's ok.

@Dropa Dropa mentioned this issue Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump PHPStan to level 2 when doing deprecations mglaman/drupal-check
2 participants
@jkribeiro @mglaman