New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't detect usage of deprecate private store class/service #106

Open

1 of 4 tasks

Berdir opened this issue Sep 24, 2019 · 1 comment

Open

1 of 4 tasks

Doesn't detect usage of deprecate private store class/service #106

Berdir opened this issue Sep 24, 2019 · 1 comment

Labels

phpstan-deprecation-rules

Berdir commented Sep 24, 2019

How is drupal-check installed?

drupal-check is installed using the phar
drupal-check is installed globally via Composer
drupal-check is installed globally using consolidation/cgr
drupal-check is installed as a dependency to my project

Environment:

OS: Linux
PHP Version: 7.2
Drupal core: 8.8.x

Describe the bug
See https://www.drupal.org/project/contact_storage/issues/3038676#comment-13270544, the constants is a known issue, but was confused about the other change in that interdiff, apparently it didn't see the deprecated service nor the injected class.

Console output

mglaman added the phpstan-deprecation-rules label

Owner

mglaman commented May 11, 2020

Yeah, this seems like weird edge case that isn't caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment