Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update indexed_geometries.py #92

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Update indexed_geometries.py #92

merged 2 commits into from
Nov 21, 2023

Conversation

jnclelland
Copy link
Collaborator

Fixed a bug in maup.assign in the case where no source is completely covered by a single target.

@jnclelland
Update indexed_geometries.py
e390a0e 
Fixed a bug in maup.assign in the case where no source is completely covered by a single target.
peterrrock2
peterrrock2 requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@peterrrock2 peterrrock2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I forgot earlier that we will need to update the version info for the patch before we push to main. I'll make this edit in a new commit to this branch really quick before we merge

@peterrrock2 peterrrock2 merged commit c5d8dd0 into master Nov 21, 2023
13 checks passed
@peterrrock2 peterrrock2 deleted the Patch-1.1.3 branch November 21, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrrock2 peterrrock2 peterrrock2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnclelland @peterrrock2