Begin moving to ES6 syntax via linting changes. #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRIngram
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begin the process of moving to ES6 syntax (which has been discussed in #194 ).
This PR achieves 3 things as part of fix:
1. Adds an explicit eslint script command to the package file.
The rationale behind this was so that the eslint rules could be tweaked to favour ES6 syntax. With an explicit linting script in place we can more easily identify where changes need to occur.
2. Change lint rule to use
let/constAs raised in #194, let / const sytanx should be favoured. The linting rules have been changed to flag
vars, and the issues have been fixed.3. Fix previous linting errors
This repository was breaking its own linting rules, such as
no-plus-plus. These have been resolved.Note: I do not believe that this totally resolves #194 and that should remain open; this PR does, however, begin that journey should make the journey easier.