Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add "blacklist-title" to the list of messages to be translated. #54

Open
TheMatheusDev opened this issue Feb 5, 2022 · 5 comments
Labels
enhancement New feature or request todo This will be implemented at some time

Comments

@TheMatheusDev
Copy link
Contributor

TheMatheusDev commented Feb 5, 2022

Intro:

Hi, your plugins are great, I can't play my survival server without them anymore, they have such great utilities. Thanks.
To make InvUnload even more good, you could make "blacklist-title" (line 229) of the "config.yml" file translatable to other languages, as the other messages already are.

Pros & Cons:

Pros:

  • Makes the messages more internationalizable without having to change default settings. Delivering a better out of the box experience. Currently, every user can translate on their own "blacklist-title", but that way the plugin doesn't deliver a complete translation experience.

Cons:

  • Making "blacklist-title" translatable breaks the pattern of translated messages (because blacklist-title contains several hyphens).
  • Add new message to be translated into all languages.

In-game example:

Below is a in-game example on a scenario with a portuguese translation containing the inconsistency :
("Blacklist" should be "Lista Negra")
blacklist

How should be:

Original line 229:

blacklist-title: "----- &cBlacklist&r -----"

Add something like #message-blacklist-title:

##### English
[...]
#message-blacklist-title: "----- &cBlacklist&r -----"  #ADD TO THE ENGLISH AND OTHER LANGUAGES TRANSLATABLE STRINGS.
#message-blacklist-empty: "&7You blacklist is empty."
#message-blacklist-added: "&2Added to blacklist:&7 %s"
#message-blacklist-invalid: "&4Invalid items:&7 %s"
[...]

Conclusion:

This implementation can be easily done.
Waiting for your answer to open a pull request with a new translation! 😉

@noramibu noramibu added enhancement New feature or request todo This will be implemented at some time labels Feb 5, 2022
@noramibu
Copy link
Contributor

noramibu commented Feb 5, 2022

Hi, for us PRs always welcome! If you are interested to implement this feature to InvUnload, we would like to review your PR :)

@noramibu
Copy link
Contributor

noramibu commented Feb 5, 2022

If i don't hear news from you, i will have a look

@TheMatheusDev
Copy link
Contributor Author

TheMatheusDev commented Feb 5, 2022

I tried renaming the "blacklist-title" to "message-blacklist-title" but that didn't worked. Looks like changes on source code needs to be done.
I took a look on Messages.java file but unfortunately i don't have the java knowledge to update and build the plugin to test myself.

The easiest (and also laziest) way make it work, it's to use the actual "blacklist-title" variable.
I don't think this alternative is the best because the config option doesn't have the "message-" prefix and doesn't follow the pattern of the others blacklist messages, such as "message-blacklist-removed", "message-blacklist-invalid"...

What do you think?

@mfnalex
Copy link
Owner

mfnalex commented Feb 5, 2022

@Cazcez Do something useful and create a Pull Request :P

Otherwise I'll do it when I have time :)

@TheMatheusDev
Copy link
Contributor Author

That was a quick reply! xD

Thanks for hearing my suggestion and sorry for not being able to do it by myself.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo This will be implemented at some time
Projects
None yet
Development

No branches or pull requests

3 participants