Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let /unloadinv check if a chest has an item frame with the itemtype on it #37

Open
Engineer9736 opened this issue Jan 23, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request todo This will be implemented at some time

Comments

@Engineer9736
Copy link
Contributor

Hi, i just came up with an idea to make /unloadinv better to use in storage rooms.

Currently a chest needs to have at least 1 item of the itemtype you want to unload in a chest to be able to unload it.

So if you empty the entire chest for a project, you need to find the right chest manually again before /unloadinv is going to work again for that itemtype.

Maybe a good solution for this issue may be to check if a chest has an itemframe on it, with the itemtype on it?

Not sure if it would take up a lot of cpu cycles (causing lag). If you have 200 double chests which have 10 possible item frame locations each, then there will be 2000 positions to check.

It could be made configurable so server admins can turn it off if it takes too much cpu usage.

What you think about this idea?

@mfnalex
Copy link
Owner

mfnalex commented Jan 23, 2021

That's a good idea, it shouldn't cause any noticeable amount of lag. However that might be a 1.13+ feature

@mfnalex mfnalex self-assigned this Jan 23, 2021
@mfnalex mfnalex added enhancement New feature or request todo This will be implemented at some time labels Jan 23, 2021
@Engineer9736
Copy link
Contributor Author

Good to hear, thanks in advance!

@Engineer9736
Copy link
Contributor Author

I guess you mean Minecraft version 1.13+, does 1.12 have (or lack) something that may not make it work?

Just curious, for me personally it's fine as i only play the most recent version of Minecraft :)

Perhaps the same reason why 2B2T is still on 1.12?

@mfnalex
Copy link
Owner

mfnalex commented Jan 23, 2021

It is of course also possible to check to what a block a block/entity is attached in 1.12, but the API lacks some features that make it very convenient. That means I would have to code the same logic twice and always check what version the server is using, and I really dont like that. Adding that feature for 1.13+ and 1.12 and below would mean 3 times as much as trouble as adding it only for 1.13.

@Engineer9736
Copy link
Contributor Author

Alright, thanks for sharing this info! 🙂 Interesting to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo This will be implemented at some time
Projects
None yet
Development

No branches or pull requests

2 participants