Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Class components to functional components #18

Open
sansyrox opened this issue Dec 4, 2020 · 19 comments
Open

Migrate the Class components to functional components #18

sansyrox opened this issue Dec 4, 2020 · 19 comments
Assignees

Comments

@sansyrox
Copy link
Member

sansyrox commented Dec 4, 2020

Now the class components are soon to be deprecated, try porting them to functional components.

@kibi11
Copy link

kibi11 commented Dec 4, 2020

Can you assign me this issue? What are the things need to know ?

@sansyrox
Copy link
Member Author

sansyrox commented Dec 4, 2020

There are class components in the app, you just need to convert them to functional components.
Ensuring you don't break anything.

@sansyrox
Copy link
Member Author

sansyrox commented Dec 7, 2020

@kibi11 , you can go ahead. Sorry forgot to assign this issue to you.

@sayna3311
Copy link
Contributor

Can you assign this to me? I would like to look into it.

@sansyrox
Copy link
Member Author

sansyrox commented Dec 7, 2020

@sayna3311 , we should wait for 2/3 days to allow @kibi11 to work on it.

@sayna3311
Copy link
Contributor

@sansyrox Can I work on it now?

@sansyrox
Copy link
Member Author

Yes @sayna3311 . Go ahead!! 🔥

@trishnakalita660
Copy link
Contributor

#43

Changed the NotFound.js into Functional component and solved the "GO TO HOME" button issue.

@MohsinAliSoomro
Copy link

Can I work on this?

@sansyrox
Copy link
Member Author

Hi @MohsinAliSoomro .

Go ahead!

@pranay-simejia
Copy link

is this issue still open? i would like to work on it.

@sansyrox
Copy link
Member Author

sansyrox commented Feb 2, 2021

Hi @pranay-simejia , yes it is still open. Please go ahead.

@sansyrox sansyrox added the easy label Feb 2, 2021
@ranveersequeira
Copy link

working on it

@ranveersequeira
Copy link

Tried but app not working now.

@sansyrox
Copy link
Member Author

Hi @ranveersequeira , please try to migrate the components in the major_refactor branch

@sansyrox
Copy link
Member Author

The main branch has been flaky ever since its inception, hence we're moving away from it

@sansyrox
Copy link
Member Author

branch name: major_refactor

@shivaylamba
Copy link

@sansyrox any updates on this issue?

@bhagyamudgal
Copy link

Can I work on this issue as it seems the issue has not been resolved yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants