Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test: delete base #63

Merged
merged 1 commit into from
Apr 27, 2024
Merged

integration test: delete base #63

merged 1 commit into from
Apr 27, 2024

Conversation

saza-ku
Copy link
Contributor

@saza-ku saza-ku commented Apr 13, 2024

base is the offset of the memory region the test codes can use in Linear Memory Address. But the value is always 0. So we don't need to use this variable.

FYI: We needed base because it was not always 0 in the midst of the development.

@saza-ku saza-ku requested a review from ainozaki April 13, 2024 15:44
ainozaki
ainozaki approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ainozaki ainozaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@saza-ku saza-ku merged commit 0c6724f into mewz-project:main Apr 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ainozaki ainozaki ainozaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saza-ku @ainozaki