Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few issues #17

Open
armenzg opened this issue Dec 20, 2017 · 2 comments
Open

Few issues #17

armenzg opened this issue Dec 20, 2017 · 2 comments

Comments

@armenzg
Copy link

armenzg commented Dec 20, 2017

I created a simple page using this package.
I just want to highlight what I believe are some issues that get on the way of adoptions and links to my code:

  1. Issue #13 - downgrade to React 15.3.0
  2. The need to import MG and use it to manipulate data. I may be doing things wrong.
  3. The need to add some CSS to make things plot properly. This is probably from use full-width.

Happy to see an official reference to this package from metrics-graphics! Good job.
Let me know if there are any issues you would like me to contribute.

@wlach
Copy link
Collaborator

wlach commented Dec 20, 2017

(1) - yep, we should fix that. :) Patches accepted! I'm guessing it should be pretty easy, because this is such a trivial package.

I think (2) is expected. There is no harm in using metricsgraphics directly for processing data.

(3) We import CSS from metrics-graphics itself in our example: https://github.com/mozilla/react-metrics-graphics/blob/cbe0d9af3c10b3950b493d33ba60d72fcb9360a6/src/index.js#L6

This might be better fixed inside metricsgraphics itself.

@armenzg
Copy link
Author

armenzg commented Feb 27, 2018

I've tried including the demo from the docs and including font-awesome's CSS is not part of the docs:
armenzg/experiments@bb57e3d#diff-eff02ea7aa3d236de286d59da20f3a42R2
or installing the package separatedly:
armenzg/experiments@bb57e3d#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R14

font-awesome is needed for the exclamation mark icon:
image

It seems that the dependency on fa is added in metrics-graphics:
https://github.com/mozilla/metrics-graphics/search?utf8=%E2%9C%93&q=fa-exclamation-circle&type=

I think we should file an issue for metrics-graphics to remove the dependency on fa or explicitely add it. What do you think?

On another note, I think that including the .css files via the html files might be something that needs addressing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants