Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:merge with registries does not round-trip #1088

Open
frenchy64 opened this issue Aug 9, 2024 · 1 comment
Open

:merge with registries does not round-trip #1088

frenchy64 opened this issue Aug 9, 2024 · 1 comment

Comments

@frenchy64
Copy link
Collaborator

If schemas with registries are merged with :merge, the dereferenced schema often cannot be round-tripped.

Notice the following schema is missing a ::z binding so is no longer well-formed.

(-> (m/deref
      [:merge
       [:map {:registry {::y int?}}
        [:y ::y]]
       [:map {:registry {::z boolean?}}
        [:z ::z]]]
      options)
    m/form)
=>
[:map {:registry {::y boolean?}}
 [:y ::y]
 [:z ::z]]

We might be able to fix this by merging the registries, but something else is needed if the registries both define the same names.

For example, here the schema for :y is being captured by the wrong scope, and becomes [:y boolean?] instead of [:y int?].

(-> (m/deref
      [:merge
       [:map {:registry {::y int?}}
        [:y ::y]]
       [:map {:registry {::y boolean?}}
        [:z ::y]]]
      options)
    m/form)
=>
[:map {:registry {::y boolean?}}
 [:y ::y]
 [:z ::y]]
@frenchy64
Copy link
Collaborator Author

frenchy64 commented Aug 13, 2024

This example doesn't work at all, and complains that ::y is not in scope.

[:merge
 [:map
  {::y boolean?}
  [:y ::y]]
 [:map]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant