Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chained tokio channels in validate endpoints #46

Open
intarga opened this issue Oct 9, 2023 · 1 comment
Open

Remove chained tokio channels in validate endpoints #46

intarga opened this issue Oct 9, 2023 · 1 comment
Labels
tech debt internal/maintainability improvements

Comments

@intarga
Copy link
Member

intarga commented Oct 9, 2023

blocked on async iterator stabilization

@intarga intarga added the tech debt internal/maintainability improvements label Oct 9, 2023
@intarga intarga self-assigned this Oct 9, 2023
@intarga intarga removed their assignment Oct 2, 2024
@intarga
Copy link
Member Author

intarga commented Oct 2, 2024

This might be unnecessary now. We can just remove the inner channel in schedule tests. The original idea behind the channel was that it was best to return flags ASAP, and the channel allowed us to do that without waiting for later tests to finish. Now I'm not so convinced of its utility. Since we won't run the combi check to generate end user flags until the full pipeline is finished, it doesn't seem like the individual flags have any use before that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt internal/maintainability improvements
Projects
None yet
Development

No branches or pull requests

1 participant