Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New minimaldata #1416

Merged
merged 4 commits into from
Nov 20, 2024
Merged

New minimaldata #1416

merged 4 commits into from
Nov 20, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Nov 20, 2024

Change Summary

Adds the hash for the new testdata minimal which includes a new EMEP file with data for 1999

Related issue number

Related to metno/pyaerocom-tutorials#19

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte self-assigned this Nov 20, 2024
@dulte dulte added the bug 🐛 Something isn't working label Nov 20, 2024
@dulte dulte added this to the m2024-12 milestone Nov 20, 2024
@lewisblake
Copy link
Member

Would you be willing to include another file in this minimal data? We talked about updating this yesterday anyway. I'll email you the file

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (23809dc) to head (6111089).
Report is 152 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1416      +/-   ##
============================================
- Coverage     78.87%   78.36%   -0.52%     
============================================
  Files           136      137       +1     
  Lines         20863    20884      +21     
============================================
- Hits          16455    16365      -90     
- Misses         4408     4519     +111     
Flag Coverage Δ
unittests 78.36% <100.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dulte
Copy link
Collaborator Author

dulte commented Nov 20, 2024

Would you be willing to include another file in this minimal data? We talked about updating this yesterday anyway. I'll email you the file

Sure. I'll add it immediately :)

@dulte dulte marked this pull request as draft November 20, 2024 13:22
@dulte
Copy link
Collaborator Author

dulte commented Nov 20, 2024

@lewisblake your file can now be found under /modeldata/colocated_netcdf/my_colocated_data.nc. It was quite large, so I cut it down to just 1 year. I hope that is OK?

@dulte dulte marked this pull request as ready for review November 20, 2024 13:37
@dulte dulte marked this pull request as draft November 20, 2024 13:39
@lewisblake
Copy link
Member

Awesome, thanks!

@lewisblake
Copy link
Member

This PR will help with metno/pyaerocom-tutorials#20 also

@dulte dulte marked this pull request as ready for review November 20, 2024 13:44
@heikoklein heikoklein merged commit de1768f into main-dev Nov 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants