Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gaw-test #1415

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix gaw-test #1415

merged 1 commit into from
Nov 20, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Nov 20, 2024

Change Summary

gaw tests on PPI failed for unknown reason

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-12 milestone Nov 20, 2024
@heikoklein heikoklein marked this pull request as draft November 20, 2024 11:54
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (7fd10ab) to head (f920966).
Report is 3 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/gaw/reader.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1415   +/-   ##
=========================================
  Coverage     78.35%   78.36%           
=========================================
  Files           137      137           
  Lines         20885    20884    -1     
=========================================
  Hits          16365    16365           
+ Misses         4520     4519    -1     
Flag Coverage Δ
unittests 78.36% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@heikoklein heikoklein marked this pull request as ready for review November 20, 2024 12:19
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you

@lewisblake lewisblake merged commit bb4a8dc into main-dev Nov 20, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the gaw_fixes branch November 20, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants