Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any argument to pyaro filters #1413

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Allow any argument to pyaro filters #1413

merged 1 commit into from
Nov 21, 2024

Conversation

magnusuMET
Copy link
Collaborator

@magnusuMET magnusuMET commented Nov 20, 2024

Change Summary

Filters should be allowed any input argument

Related issues

Found when trying to use the relaltitude filter, which requires a str and float, neither of which are allowed by the type validator

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@magnusuMET magnusuMET added this to the m2024-12 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (b60d3fa) to head (975e047).
Report is 18 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1413   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
=========================================
  Files           137      137           
  Lines         20887    20888    +1     
=========================================
+ Hits          16365    16366    +1     
  Misses         4522     4522           
Flag Coverage Δ
unittests 78.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@magnusuMET magnusuMET marked this pull request as ready for review November 20, 2024 09:26
@magnusuMET magnusuMET marked this pull request as draft November 20, 2024 12:19
@magnusuMET
Copy link
Collaborator Author

Any might lead to strange serialisation/deserialisation giving garbled output. Need to investiage this further

@magnusuMET magnusuMET marked this pull request as ready for review November 21, 2024 10:44
@magnusuMET
Copy link
Collaborator Author

Serialisation/deserisalistion bug is not related to this PR, and is reported in #1417

@heikoklein heikoklein merged commit e36edb9 into main-dev Nov 21, 2024
8 checks passed
@heikoklein heikoklein deleted the pyaro_filter_args branch November 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants