Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io/gaw/test_dms.py test failure on main-dev #1412

Closed
thorbjoernl opened this issue Nov 19, 2024 · 2 comments
Closed

io/gaw/test_dms.py test failure on main-dev #1412

thorbjoernl opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies testing
Milestone

Comments

@thorbjoernl
Copy link
Collaborator

thorbjoernl commented Nov 19, 2024

Describe the bug
Please provide a clear and concise description of what the bug is.

  • Pyaerocom version: 0.25.0.dev0
  • Computing platform: NA
  • Configuration file (if applicable): NA
  • Error message (if applicable):

Most recent numpy (2.1.3):

DeprecationWarning: numpy.core is deprecated and has been renamed to numpy._core. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.defchararray.
TypeError: np.char.add() requires both arrays of the same dtype kind, but got dtypes: 'object' and '<U1' (the few cases where this used to work often lead to incorrect results).

Happens here

To Reproduce
Steps to reproduce the behavior:

  1. Pull most recent main-dev and ensure packages are updated (eg. pip install -e --upgrade)
  2. pytest tests/io/gaw/test_dms.py

Expected behavior
No error

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

  • Seems unrelated to numpy in itself as an error occurs with a 1.X.Y release as well.
  • May be related to changes in iris / scitools.
  • I suspect the lines where the error happens weren't previously executed as part of the tests, as the np.core->np._core deprecation happened a long time ago.
@thorbjoernl thorbjoernl added bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies labels Nov 19, 2024
@thorbjoernl thorbjoernl added this to the m2024-12 milestone Nov 19, 2024
@thorbjoernl
Copy link
Collaborator Author

I installed the exact dependencies from the numpy bump branch and reran the tests on both main-dev and the numpy branch from last week and these tests fail on the former and pass on the latter. I take this to mean that this is not caused by a dependency.

@heikoklein
Copy link
Member

fixed by #1415

@heikoklein heikoklein self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies testing
Projects
None yet
Development

No branches or pull requests

2 participants