Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breite-Light.ufo refers to “component_1” without defining it #1

Open
brawer opened this issue Feb 16, 2016 · 4 comments
Open

Breite-Light.ufo refers to “component_1” without defining it #1

brawer opened this issue Feb 16, 2016 · 4 comments

Comments

@brawer
Copy link

brawer commented Feb 16, 2016

In Breite-Light, glyph uni090E refers to “component_1” which is not defined by the font. Because of this dangling reference, fontmake cannot build the font.

@graphicore
Copy link
Member

This reminds me of a finding I made recently: Tarobish/Katibeh#94 (comment)

I was looking in the ufos exported by Glyphs.
Glyphs doesn't translate all of the component names correctly into production names when exporting the ufo:

@graphicore
Copy link
Member

This reminds me …

But this is different, there's no other glyph that could be component_1 with a mangled name.

@brawer I am wondering, while the UFO docs say nothing about how to handle missing components, the pen protocol is explicit in skipping them, see: https://github.com/behdad/fonttools/blob/master/Lib/fontTools/pens/basePen.py#L197 If you would use a normal segment pen in fontmake, it should just drop the missing component without further notice. This is may be the reason why other ufo-consumers did not complain earlier about such files. But, I'm not aware of each component handling case in ufoLib. Is the source of your error in ufoLib? I guess the source of the UFO here is Glyphs, so someone should have noticed this before—well, or not.

@brawer
Copy link
Author

brawer commented Feb 16, 2016

Just double-checking before nagging the Glyphs folks: can you confirm that Breite-Light.ufo was indeed written by Glyphs?

@graphicore
Copy link
Member

Good call, and I don't know in fact :-) @nicolasfpauly how did you make these ufos?

Seems, like I was wrong BTW:
https://github.com/metapolator/Breite/blob/master/Breite%20Light/Light.ufo/metainfo.plist#L6

<key>creator</key>
<string>org.robofab.ufoLib</string>

While a recent ufo generated by glyphs:
https://github.com/Tarobish/Mirza/blob/master/Generated/Arabic/Mirza-Regular.ufo/metainfo.plist#L6

    <key>creator</key>
    <string>com.schriftgestaltung.GlyphsUFOExport</string>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants