-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use presentation-metadata for colours #698
Comments
For the names of the colors can we make them meaningful? Since this is an exercise we would likely not revisit in a long time. Thanks. |
I propose to rename the colors as follows
Also, there are more colors that should be added:
|
OK, that's fine by me. I will note though that I am having trouble with the mapping to the HTML colours, and I may have questions. Proceeding with these renamings. |
Oh, for the distinction between deprecated and admitted: I see that in Presentation XML, both are labelled "AdmittedLabel". I will change deprecated to be labelled "DeprecatedLabel", to simplify the test; I had not been differentiating them until now. |
|
OGC XSLT updated in metanorma/mn-native-pdf#720. |
I've submitted the HTML outputs for review, I'll ask that they get to it this week... |
@opoudjis there is a mention here for legacy colors being outputted with the We should actually refactor out the legacy design to a new "layout" like we have for ISO, so it is consistent across flavors. |
You misunderstand:
This is not a legacy colour, and it will not be treated as one. |
OK, thanks @opoudjis . |
This is going to take months to resolve, @Intelligent2013, I'm going to try and create a version of the PR that leaves the PDF unaffected. But for now, ignore all rendering colours associated with admonitions, and stick with original colours. |
Updated OGC XSLT in PR metanorma/mn-native-pdf#720. On hold. |
I've added the default colors into OGC XSLT. They will be applied if colors are missing in the |
OGX xslt updated for colors, metanorma/metanorma-ogc#698
Really sorry about the delay. I will merge the PR and ignore it in my HTML CSS, so at least you won't be impacted. |
From #673:
colours are going to be included in Presentation XML metadata from now on, including the logic about the dependence of colours on the schema. That is so that there is a single source of truth about colours for both HTML and PDF:
The text was updated successfully, but these errors were encountered: