Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken (more like undefined) PubID for committee document with stage #1195

Open
ronaldtse opened this issue Jul 25, 2024 · 7 comments
Open
Assignees

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Jul 25, 2024

Is this a PubID issue?

Screenshot 2024-07-25 at 10 04 39 PM Screenshot 2024-07-25 at 10 04 29 PM

Because the docstage being 20/20 the PubID is now wrong.

Right now it is shown as:

  • ISO/TCWD 184/SC 4/WG 12 N11498

Technically we have no defined the PubID for N-documents, because usually N-documents are replaced per version.

Taking the pattern of "{publisher}/{stage} {number}", perhaps it should be:

  • ISO/TC 184/SC 4/WG 12/WD N11498

Metadata:

= Validation report for conversion of ISO 10303 parts from PDF form to a model-based form
:docnumber: 11498
:edition: 1
:revdate: 2024-07-17
:copyright-year: 2024
:language: en
:title-intro-en: SMRL Innovation
:title-intro-fr: Innovation de SMRL
:title-main-en: Validation report for conversion of ISO 10303 parts from PDF form to a model-based form
:title-main-fr: Rapport de validation pour la conversion des pièces ISO 10303 d'un formulaire PDF à un formulaire basé sur un modèle
:doctype: committee-document
:docstage: 20
:docsubstage: 20
:secretariat: ANSI
:technical-committee-number: 184
:technical-committee: Industrial Automation Systems and Integration
:subcommittee-number: 4
:subcommittee: Industrial Data
:workgroup-number: 12
:workgroup-type: WG
:workgroup: STEP product modelling and resources

The document is at:

@opoudjis
Copy link
Contributor

opoudjis commented Aug 2, 2024

The identifier generation for ISO identifiers is completely delegated to pubid, by design. I have no idea how N is even ending up in the identifier. This is for @mico

@mico
Copy link

mico commented Aug 12, 2024

@ronaldtse yes, it's pubid issue. For the reason I don't know I left stage rendering in Technical Committee identifier rendering, but I cannot find anything about stages for TC identifiers anywhere and removing rendering "stages" doesn't make any tests crash.

@opoudjis
Copy link
Contributor

This is being generated with the parameters:

{:number=>"11498", :type=>:tc, :publisher=>"ISO", :stage=>"20.20", :sctype=>"SC", :scnumber=>"4", :tctype=>"TC", :tcnumber=>"184", :wgtype=>"WG", :wgnumber=>"12"}

@mico
Copy link

mico commented Aug 12, 2024

This is being generated with the parameters:

{:number=>"11498", :type=>:tc, :publisher=>"ISO", :stage=>"20.20", :sctype=>"SC", :scnumber=>"4", :tctype=>"TC", :tcnumber=>"184", :wgtype=>"WG", :wgnumber=>"12"}

@opoudjis yes, with this input we get stage in output.
@ronaldtse should we ignore the stage and produce output without, or we should add stage to output? (it will be first known TC identifier with stage)

@ronaldtse
Copy link
Contributor Author

@opoudjis @mico there are 2 types of ISO IDs now:

  • ISO standard IDs
  • ISO N-document IDs

These two types of IDs need to be handled separately.

ISO N-document IDs do not show stages.

@mico
Copy link

mico commented Aug 14, 2024

  • ISO N-document IDs

@ronaldtse is there other N documents except TC documents? (ISO/TC)

@ronaldtse
Copy link
Contributor Author

@ronaldtse is there other N documents except TC documents? (ISO/TC)

No. TC documents the "N documents" because they have an "N-number".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏔 High priority
Development

No branches or pull requests

3 participants