Sensitive data

[RamezIssac]

Hello there 👋
I came across Sonar, read through the code, and i like the idea.
Jus noticed that you're saving POST data into the database and wanted to raise the concern that it might contains sensitive data like passwords etc..

Good initiation, keep it up mate !

[metalogico]

Hello!
Yes, I know it could contain sensitive data. It's hard to avoid that, but I have few ideas to keep the database clean.
Right now I'm working on extending django-sonar features but after that I will take a look into this matter.
Thanks for the heads up!

[RamezIssac]

Check django.views.decorators.debug.sensitive_post_parameters decorator
https://docs.djangoproject.com/en/dev/howto/error-reporting/#django.views.decorators.debug.sensitive_post_parameters

Quick example:

from django.views.decorators.debug import sensitive_post_parameters

@sensitive_post_parameters
def login_view(request):
    return HttpsResponse()

# then in your middleware, when writing the log 
for key, val in request.POST:
    if  request.sensitive_post_parameters == "__ALL__" or key in request.sensitive_post_parameters:
        # sensitive
    else:
        # safe
        

:)

[metalogico]

Exactly! Something along those lines. Thanks