Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ip certificates #39

Closed
aviramha opened this issue May 9, 2022 · 5 comments
Closed

Support ip certificates #39

aviramha opened this issue May 9, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@aviramha
Copy link
Member

aviramha commented May 9, 2022

After we transitioned into using RustTLS in #33 we found out that RustTLS doesn't work with IP hosts, hence causing mirrord to not work in cases like minikube, which is required for #35.
Solution seems to be using https://github.com/rustls/rustls-native-certs + building kube rs client and adding those certificates.

@aviramha aviramha added the enhancement New feature or request label May 9, 2022
@aviramha aviramha added this to the 2.0 milestone May 9, 2022
@aviramha
Copy link
Member Author

Seems like we can fix it upstream by respecting certificate authority configuration of the kube config.
kube-rs/kube#89
@infiniteregrets will see if he can fix it upstream then we use his fork until it's merged.

@aviramha
Copy link
Member Author

Following the trails, it seems the issue is actually rustls/rustls#184 that can be fixed only after briansmith/webpki#260

@aviramha aviramha changed the title Support local certificates Support ip certificates May 10, 2022
@aviramha
Copy link
Member Author

#47 helps elevate the issue for now, but keeping this open until upstream is merged and it's really fixed.

@eyalb181
Copy link
Member

@aviramha So we have a workaround for this, right? Can we remove it from the 2.0 Milestone?

@aviramha
Copy link
Member Author

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants