Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI Benchmark Issue regarding Clusterrole of csi-lvm #200

Open
majst01 opened this issue Jul 23, 2021 · 0 comments · May be fixed by #207
Open

CSI Benchmark Issue regarding Clusterrole of csi-lvm #200

majst01 opened this issue Jul 23, 2021 · 0 comments · May be fixed by #207
Assignees
@majst01
Labels
cosmetic good first issue Good for newcomers

Comments

@majst01
Copy link
Contributor

majst01 commented Jul 23, 2021

It should be listed explicitly which verbs on the pods should be possible for the csi-lvm instead of wildcard(*).

This is set actually here: https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/charts/internal/shoot-storageclasses/templates/storageclasses.yaml
I propose instead to limit this to:

create, delete, get, list, patch, update, watch
@majst01 majst01 self-assigned this Jul 23, 2021
mwennrich added a commit that referenced this issue Sep 2, 2021
@mwennrich
list csi-lvm clusterroles verbs explicitly
1165a69 
Fixes #200
@mwennrich mwennrich linked a pull request Sep 2, 2021 that will close this issue
Draft
1 task
@Gerrit91 Gerrit91 added cosmetic good first issue Good for newcomers labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majst01 majst01

Labels
cosmetic good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve csi-lvm storageclasses.yaml template metal-stack/gardener-extension-provider-metal
2 participants
@majst01 @Gerrit91